raphinesse opened a new pull request #1267: URL: https://github.com/apache/cordova-android/pull/1267
### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> This reduces usage of `check_reqs.get_target` since that function only considers `config.xml` to find the target SDK and moreover relies on the script location to find `config.xml` (which has to change if we want to run the script from node_modules). ### Description <!-- Describe your changes in detail --> When looking for the best emulator image to run an APK on, the target SDK of that APK is determined by running `apkanalyzer manifest target-sdk`. ### Testing <!-- Please describe in detail how you tested your changes. --> - ran unit tests - manually tested that the correct SDK is inferred from the built APK during `cordova run` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
