raphinesse opened a new pull request #1269:
URL: https://github.com/apache/cordova-android/pull/1269
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Finally, the moment we've all been waiting for! :tada: :wink:
This PR does away with the questionable practice of copying the entire JS
lib of `cordova-android` into each generated platform project – which had
caused several issues and complications in the past.
### Description
<!-- Describe your changes in detail -->
- create: do not copy our JS lib (or `node_modules`) to platform project
- Move files around
- `bin/templates/cordova/lib/` to `lib/`
- `bin/templates/cordova/Api.js` to `lib/`
- `bin/lib/create.js` to `lib/`
- `bin/templates/cordova/lib/plugin-build.gradle` to `lib/builders`
After these changes, the `cordova/` folder of a generated project only
contains the bare minimum to maintain compatibility with existing cordova CLI
versions (plus `defaults.xml` which IMHO should be moved in another PR). All of
the remaining JS files in that folder require their dependencies via the
`cordova-android` module, so that needs to be resolvable somehow (which is the
case for a platform project generated by the regular CLI workflow).
### Testing
<!-- Please describe in detail how you tested your changes. -->
- existing tests pass
- I successfully created and built a cordova-android project using cordova@10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
