NiklasMerz opened a new pull request #1275:
URL: https://github.com/apache/cordova-android/pull/1275


   
   
   <!--
   Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist is intended as a quick reference, for complete details please 
see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Addresses issue described in #1217
   
   
   ### Description
   <!-- Describe your changes in detail -->
   
   With the introduction of the WebViewAssetloader #1137 and the Allow List 
Plugin #1138 we need to add the origin / href the app is running to the 
allowlist.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   Create a blank new app with one plugin
   
   ```
   cordova create test
   cd test
   cordova platform add 
https://github.com/apache/cordova-android#webviewassetloader-allowlist
   cordova plugin add cordova-plugin-file
   cordova run android
   ```
   
   These steps will produce the hello world cordova app that should show 
"deviceready" with this pr. See issue.
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to 
one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to