breautek commented on pull request #892: URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/892#issuecomment-883512942
> > Hi there, > > First I'd like to thank you for your time in preparing this PR. I was able to give this a glance over and there's a few main things that I want to point out. > > > > 1. There are new classes added that needs to be licensed under the Apache license for Apache to accept the code. If you have permission from the original author to re-license the code under the [Apache License](https://www.apache.org/licenses/LICENSE-2.0), then the Apache license headers needs to be added. Otherwise we cannot accept the Pr unfortunately. > > 2. This PR adds maintenance support for code going back as Android 3.0 (API 11). Cordova only supports API >= 22 and adding conditional logic to support anything less adds unnecessary complexity. I would like to see this simplified by removing any extra code required to support APIs < 22. > > > > Kind regards, > > Norman > > Hey Norman, > I would gladly update the code as you have requested. But it might take me some time. Hope you understand. To hopefully save you some time, I think it would be best to analyse and see if you can fulfil the original requirements to solve https://github.com/apache/cordova-plugin-inappbrowser/issues/320 without using the code by Cristian Perez. The original code appears to be licensed under MIT, and while that may allow you to copy the code for your own use, all code submitted to Apache needs to be licensed under the Apache license. So either the code By Christian needs to be removed, or we need obtain written permission to be able to license that code under Apache. If this cannot be done, then we should close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
