erisu commented on issue #759:
URL: 
https://github.com/apache/cordova-plugin-camera/issues/759#issuecomment-911104863


   @codeconsole Can you explain how you are testing the PR changes?
   
   When I took a photo using the changes from #712, the GPS Exif data does not 
exist.
   
   JavaScript Sample:
   
   ```js
   const cameraOptions = {
     quality: 100,
     destinationType: Camera.DestinationType.FILE_URI,
     sourceType: Camera.PictureSourceType.CAMERA,
     encodingType: Camera.EncodingType.JPEG,
     mediaType: Camera.MediaType.PICTURE,
     saveToPhotoAlbum: true,
   }
   
   cameraTakePhoto.onclick = function() {
     navigator.camera.getPicture(onPhotoDataSuccess, onFail, cameraOptions);
   };
   ```
   
   config.xml Sample
   ```xml
   <platform name="ios">
       <preference name="CameraUsesGeolocation" value="true" />
   
       <edit-config target="NSCameraUsageDescription" file="*-Info.plist" 
mode="merge">
           <string>need camera access to take pictures</string>
       </edit-config>
   
       <edit-config target="NSPhotoLibraryUsageDescription" file="*-Info.plist" 
mode="merge">
           <string>need photo library access to get pictures from there</string>
       </edit-config>
   
       <edit-config target="NSLocationWhenInUseUsageDescription" 
file="*-Info.plist" mode="merge">
           <string>need location access to find things nearby</string>
       </edit-config>
   
       <edit-config target="NSPhotoLibraryAddUsageDescription" 
file="*-Info.plist" mode="merge">
           <string>need photo library access to save pictures there</string>
       </edit-config>
   </platform>
   ```
   
   From iOS's "Photo" app, I selected the photos from the gallery and 
airdropped them to my macOS. I opened the JPG photos with the "Previewer" app 
and opened the "Show Inspector" > "More Info" tab > "Exif" sub-tab. In this 
tab, there is no GPS location data.
   
   From iOS's "Photo" app, I also tried checking by the "Places" category, and 
it's not there.
   
   After taking the photo and clicking on the "Select" button, the location 
permission request dialog did open. I tried both options, "Allow Once" and 
"Allow While Using App" but neither of them made a difference.
   
   There was also a minor issue that I noticed while testing. The location 
permission dialog will automatically close itself after a few seconds. This 
does not give people enough time to read and confirm. The dialog should not 
close until the user responds.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to