usernuno opened a new issue #1343: URL: https://github.com/apache/cordova-android/issues/1343
# Bug Report The change that adds an entry to `allowedNavigations` for the added `WebViewAssetLoader` disregards logic from preferences. ## Problem The problem is in the change introduced here: https://github.com/apache/cordova-android/pull/1275 The `CordovaPreferences` object is never filled, so it has no keys/values. Therefore lines 87 and 88 in the diff above always use the default values. In the end, no matter the values of preferences `AndroidInsecureFileModeEnabled` and `hostname`, `https://localhost` is always added to the `allowedNavigations`. ### What is expected to happen? Only when `AndroidInsecureFileModeEnabled` is false, should an entry be added to `allowedNavigations`. That entry must use the value from `hostname` when provided. At least it was what I could gather from the code. ### What does actually happen? `https://localhost` is always added to the `allowedNavigations`, and no entry based on `hostname` is added. ### Version information Cordova-android 10.1.0 ## Checklist <!-- Please check the boxes by putting an x in the [ ] like so: [x] --> - [x] I searched for existing GitHub issues - [x] I updated all Cordova tooling to most recent version - [x] I included all the necessary information above -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
