airdrummingfool commented on pull request #226: URL: https://github.com/apache/cordova-paramedic/pull/226#issuecomment-942584616
@erisu Thanks for pointing this out. I didn't look at the regex because in my testing, the original change in this PR was enough to bypass the crash and complete the tests. However, looking into it more, you're right - the regex will not generate any matches as-is, and should be adjusted. I've changed the code a bit to account for the difference, and the regex now correctly finds matches. The only thing I can find that this materially affects is that `cordova-paramedic` couldn't uninstall the app from the simulator without the new changes (which didn't stop the tests from proceeding, which is why I didn't notice it in my original testing). One small note: I wasn't sure how best to handle ` Simulator` being a part of the new output. It could be integrated into the regex, but it seemed like that would make it more brittle (and possibly cause issues across languages?) so I added separate code to remove ` Simulator` from the line before the regex is run. It's still not language-independent, but at least it can be changed easily if it becomes necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
