breautek commented on issue #147:
URL: 
https://github.com/apache/cordova-plugin-device/issues/147#issuecomment-947677185


   Looking at the code, I believe this is working as expected. These are apples 
model versions, which doesn't necessarily correspond with the actual 
phone/machine name.
   
   Apple doesn't provide an actual mapping afaik, but someone built a mapping 
[here](https://github.com/squarefrog/UIDeviceIdentifier/blob/master/UIDeviceIdentifier/UIDeviceHardware.m)
   
   However, I do agree that our documentation is not clear by this. If Apple 
provides an API to obtain the user-facing model version, I'd personally vote in 
favour of deprecating the current `model` attribute in favour of a new 
attribute that returns the actual model name as the docs suggests, and add a 
quirk note on the `model` attribute.
   
   Otherwise if Apple doesn't provide any such API then I'd personally be in 
favour for just simply adding a quirk note to the docs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to