raphinesse opened a new pull request #1190: URL: https://github.com/apache/cordova-ios/pull/1190
### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Progresses https://github.com/apache/cordova/issues/16 and https://github.com/apache/cordova/issues/7 ### Description <!-- Describe your changes in detail --> Use `execa` for any subprocess spawning. #### A few notes `execa` has no equivalent of `superspawn`'s `printCommand` option (if set to `true`, it emits a verbose log of the command being executed). In the current state of this PR, those verbose logs are removed without a substitute. `superspawn` promises resolve to the captured stdout, while `execa` resolves to an object with more properties. In many of the cases where we spawn subprocesses, this does not matter, since we we only care about promise fulfillment. `superspawn` allowed to subscribe to a running process' output by means of Q's `progress` method. This basically directly translates to subscribing to `data` events on the backing streams. So that is what we used to replace these calls. However, the existing code seems to assume that the data emitted are whole lines of output only. This is by no means guaranteed, so we added `FIXME` comments to the code. ### Testing <!-- Please describe in detail how you tested your changes. --> - Existing tests pass - It would be great if someone could do some manual tests with the platform (I own no Apple computer) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
