BigBalli commented on PR #168: URL: https://github.com/apache/cordova-plugin-device/pull/168#issuecomment-1094368648
Sorry, first time contributing to a Cordova repo. - I only tested the changes locally, didn't run specific automated tests (not sure what testing environment/workflow you usually use.) - prefixed the commit with platform. - not related to an existing issue - didn't update the documentation Please let me know how to proceed, G > On Apr 9, 2022, at 10:35 PM, エリス ***@***.***> wrote: > > > Can you fill out the PR description, following the template? > > And if it is to close a ticket also link the ticket. For example: Closes #<ticket number> > > Also when I glanced the code, why are you stripping out the non-alphanumeric? > > What happens if the device name is in another language such as Japanese, Chinese, etc? > > — > Reply to this email directly, view it on GitHub <https://github.com/apache/cordova-plugin-device/pull/168#issuecomment-1094184071>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADIM3V46FSPDCKQ2ARWF2LVEJSA5ANCNFSM5TADQZVQ>. > You are receiving this because you authored the thread. > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
