erisu commented on code in PR #238: URL: https://github.com/apache/cordova-plugin-media-capture/pull/238#discussion_r854837574
########## plugin.xml: ########## @@ -34,7 +34,7 @@ xmlns:android="http://schemas.android.com/apk/res/android"; <engine name="cordova-android" version=">=6.3.0" /> Review Comment: You need to also change this: ```xml <engine name="cordova-android" version=">=10.0.0" /> ``` The file plugin `7.0.0` implemented the `WebViewAssetLoader` proxy handler to try and continue to support something like the `cdvfile` process but in a new manner. The `WebViewAssetLoader` is a part of the `AndroidX` library and cordova-android 10.x is when `AndroidX` was introduced. If this is not updated, there will be build failures because the older platform versions does not support the latest libraries. ########## plugin.xml: ########## @@ -34,7 +34,7 @@ xmlns:android="http://schemas.android.com/apk/res/android"; <engine name="cordova-android" version=">=6.3.0" /> </engines> - <dependency id="cordova-plugin-file" version="^6.0.0" /> + <dependency id="cordova-plugin-file" version=">=6.0.0" /> Review Comment: IMO this should either be ```xml <dependency id="cordova-plugin-file" version="^7.0.0" /> ``` or ```xml <dependency id="cordova-plugin-file" version=">=7.0.0" /> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
