erisu commented on issue #1463: URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1216702448
It was an unintentional change. There is no reason why it can not go back to the original behavior. I created code changes locally that should revert to the original behavior, but have not been tested yet. I can push a branch and create a PR if you like to test. Also, as a note, I still do not see a valid benefit for mixing the manual and automatic hiding. For example, from the ticket description: > My app was previously able to close the splash screen manually so I had `AutoHideSplashScreen` set to `true`,` SplashScreenDelay` set to `10000` and simply used `navigator.splashscreen.hide()` to close the splash screen when my app is ready (depending on the device and connection quality 1-4s). In the worst case it would close after 10s. If the app hits the 10-second worst-case scenario and you used Cordova to hide the splash screen, then **what will the end user see? A white screen?** I was thinking in these more advanced scenarios, it is up to the app developer to control the timeout, from the app level. So in the above case, the 10 seconds countdown would be in the app's javascript code, and then when 10 seconds are reached, the app can decide what to do. For example, hide the splash screen and prepare and render a static "Failed To Fetch Data" screen or whatever warning. As the changes were made, for supporting Android 12 Splash, I tried to support as many of the previous preferences as possible and tried to keep the original behavior. Some couldn't be retained perfectly, but as for the AutoHide preference, I was looking at it, as if it was used only for a simple use case. For example, a simple application that was designed to use primarily static HTML, and JS, and didn't require external data. How everyone used these flags and mixed them was not something I was completely aware of. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
