jcesarmobile opened a new pull request, #1487:
URL: https://github.com/apache/cordova-android/pull/1487

   closes https://github.com/apache/cordova-android/issues/1475
   
   `windowSplashScreenBrandingImage` is not valid, it should be 
`android:windowSplashScreenBrandingImage`.
   
   All other values should also include the `android:`, but the support library 
allows to use them without the `android:` part, but since 
`windowSplashScreenBrandingImage` is not supported by the support library apps 
fail to compile.
   
   This PR adds the `android:` prefix to the value so it gets added to the 
styles file with the prefix.
   Needed to patch how the cdvConfigPrefKey is generated to strip the android: 
part of the themeKey


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to