breautek commented on PR #814: URL: https://github.com/apache/cordova-plugin-camera/pull/814#issuecomment-1324069224
> according to [Android docs](https://developer.android.com/reference/android/Manifest.permission#WRITE_EXTERNAL_STORAGE) , WRITE_EXTERNAL_STORAGE permission has no effect since Android 11 (API 30). The right code would be to set max sdk to 29 on this permission entry ? Yes, it's actually been obsolete since scoped storage, which enabled in API 29, but can be opt out back to API 28 behaviour via `requestLegacyExternalStorage`. Starting in API 30, Scoped storage is forcefully enforced which makes the `WRITE_EXTERNAL_STORAGE` obsolete since API 30. However changing the manifest may have caveats on how it's handled in the code. For example... requesting permission even if it's a no-op is OK as long as it's declared, but attempting to request permission while not being declared I think will throw an error. So for sake of simplicity, I think we may want to keep it as maxSdkVersion `32` so that we can use the API 33 check as the PR stands now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
