jfoclpf commented on PR #814:
URL:
https://github.com/apache/cordova-plugin-camera/pull/814#issuecomment-1436109686
@ochakov thanks a lot for your amendments
I just tested now and `WRITE_EXTERNAL_STORAGE` with `maxSdkVersion` creates
a huge list of conflicts with other (also official, such as file) plugins.
Other plugins don't mention `maxSdkVersion` for `WRITE_EXTERNAL_STORAGE` which
creates a build failure. Please do kindly remove `maxSdkVersion` for
`WRITE_EXTERNAL_STORAGE` (at least for now, maybe later `maxSdkVersion` can be
added at same time for all official plugins).
On the other hand `READ_MEDIA_IMAGES` and `READ_MEDIA_VIDEO` are totally new
permissions introduced only in API 33, thus do kindly add
`android:minSdkVersion="33"` to these
Do kindly thus amend to the following:
```xml
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"
/>
<uses-permission android:name="android.permission.READ_MEDIA_IMAGES"
android:minSdkVersion="33" />
<uses-permission android:name="android.permission.READ_MEDIA_VIDEO"
android:minSdkVersion="33" />
```
I tested now with these amendments on Android 12 (API 32) and 13 (API 33)
and it builds and works just fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
