erisu commented on issue #1388: URL: https://github.com/apache/cordova-android/issues/1388#issuecomment-1484448152
@gwynjudd I think the `deliverPermissionResult` method is deprecated and can be removed. If I remember correctly, this entire helper class orginated from Apache's `cordova-plugin-compat` plugin. That plugin has long been deprecated. [Its version of the helper class had and used the `deliverPermissionResult` method](https://github.com/apache/cordova-plugin-compat/blob/master/src/android/PermissionHelper.java#L74). I believe the class was copied over to make it available for other plugins and was apart of Cordova-Android 5 backwards compatability support. https://github.com/apache/cordova-android/issues/594 As for removing `onRequestPermissionResult`, I do not think this will be easy without breaking the plugins. Eventhough Apache has added the deprecated flag and updated Apache core plugins to not use the method, there are many unmaintained third-party plugins that works with the current version of Cordova-Android and could be calling the deprecated method. If we remove the method, than all those plugins will stop working. There might have been some agreement that this step has to be taken either way, but when? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
