ollm opened a new pull request, #1333: URL: https://github.com/apache/cordova-ios/pull/1333
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected iOS ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Currently `shouldOverrideLoadWithRequest` only returns the `request` and `navigationType`, the plugin I'm working with needs to check if `navigationAction.sourceFrame` is null or not to decide whether to open the url in the browser, currently I can't do that (far as I know). ### Description <!-- Describe your changes in detail --> Added a new `shouldOverrideLoadWithRequest:navigationAction` selector to have full access to the `navigationAction` object. ### Testing <!-- Please describe in detail how you tested your changes. --> I have kept the old implementation so that plugins that already use it are not affected, with the change both the old and the new one work correctly. I don't know if there is a better way to implement this, since my knowledge of `Objective-C` is basic, or if it would be better to replace completely with the new one, to avoid redundancy. ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
