breautek commented on code in PR #262:
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/262#discussion_r1231029180
##########
src/android/Capture.java:
##########
@@ -79,10 +77,18 @@ public class Capture extends CordovaPlugin {
private static final int CAPTURE_PERMISSION_DENIED = 4;
private static final int CAPTURE_NOT_SUPPORTED = 20;
- private static final String[] storagePermissions = new String[]{
- Manifest.permission.READ_EXTERNAL_STORAGE,
- Manifest.permission.WRITE_EXTERNAL_STORAGE
- };
+ private static String[] storagePermissions;
+ static {
+ if (android.os.Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
+ storagePermissions = new String[]{
Review Comment:
Originally thought this was a mistake, however reading through the PR I see
the list is added onto on demand.
Not a merge blocker but perhaps add a comment to make this clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
