breautek opened a new pull request, #589: URL: https://github.com/apache/cordova-plugin-file/pull/589
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Adds a TS check on our type def files. ### Description <!-- Describe your changes in detail --> Adds Typescript 5.1 as a dev dependency and updates the test script to run tsc to see if our types will at least compile. There is an empty .ts file as an entry point for tsc, but it could be expanded in the future to actually make use of the API and ensure that types will compile as expected. ### Testing <!-- Please describe in detail how you tested your changes. --> Ran npm test Tests will fail without a PR fix such as https://github.com/apache/cordova-plugin-file/pull/588 ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] I added automated test coverage as appropriate for this change - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [x] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
