ath0mas commented on PR #581: URL: https://github.com/apache/cordova-plugin-file/pull/581#issuecomment-1679425629
@EYALIN can you please correct the indentation. Also, remove the private field `permissions` which is never used (lines 102-116). And why not completly removing this whole methods `hasWritePermission` and `getWritePermission`? since cordova-plugin-file v8 requires cordova-android 12+ with support for Android 24+, while `WRITE_EXTERNAL_STORAGE` is not supported since 19. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
