breautek commented on code in PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#discussion_r1451637860
##########
framework/build.gradle:
##########
@@ -50,8 +50,8 @@ android {
buildToolsVersion cordovaConfig.BUILD_TOOLS_VERSION
compileOptions {
- sourceCompatibility JavaVersion.VERSION_1_8
- targetCompatibility JavaVersion.VERSION_1_8
+ sourceCompatibility JavaVersion.VERSION_17
Review Comment:
Added `AndroidKotlinJVMTarget`, which will only be effective if kotlin is
enabled (by default its disabled but there is an existing preference to enable
it). The default value is for the JVM target `1.8`.
Unlike the java source / target compatibility, `AndroidKotlinJVMTarget` only
applies to the app target, not the cordova framework. Cordova framework
currently doesn't setup/enable kotlin nor does it use kotlin, so it doesn't
read or set the JVM target. Trying to do so will cause build errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
