erisu opened a new pull request, #263: URL: https://github.com/apache/cordova-electron/pull/263
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected electron ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> update to use latest released electron ### Description <!-- Describe your changes in detail --> * Bump `electron` dependency to `^28.1.4` * Replace deprecated usage `protocol.registerFileProtocol` with `protocol.handle` * Remove deprecated usage `protocol.interceptFileProtocol` * Disabled `sandbox` setting. (When sandbox is enabled, appears that preload scripts and other require statements fails). * Future Task: Review and determin if we can support `sandbox` as optional, or completely migrate to `sandbox`. Needs to support Cordova plugin ecosystem. (third-party npm package support) ### Testing <!-- Please describe in detail how you tested your changes. --> * `npm t` * `cordova run electron --nobuild` * Confirmed that when `scheme` is set, `file` becomes inaccessible. (Should mimic previous behavior of `interceptFileProtocol`) ### Checklist - [x] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org