dpogue opened a new pull request, #1470:
URL: https://github.com/apache/cordova-ios/pull/1470

   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   Closes GH-526.
   Closes GH-1366.
   Closes GH-1377.
   Closes GH-1469.
   
   
   ### Description
   <!-- Describe your changes in detail -->
   Changed `getDefaultSimulatorTarget()` to reject with an error message when 
no simulators are found.
   
   This should at least return a useful and actionable error message to the end 
user, rather than "Cannot read property name of undefined".
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Existing unit tests pass.
   Added unit test to confirm the function now rejects when no simulators are 
present.
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to