dpogue opened a new pull request, #212: URL: https://github.com/apache/cordova-common/pull/212
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected iOS ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Currently the Info.plist file in a generated iOS project is prefixed with the project name (i.e., `HelloCordova-Info.plist`), and plugins have to set up their `config-file`/`edit-config` directives to use wildcards like `**/*-Info.plist`. The standard way for Xcode projects is to just have `Info.plist` in the project, and this gets us one step closer to supporting that. ### Description <!-- Describe your changes in detail --> * Try to find an unprefixed Info.plist, falling back to the AppName-Info.plist * Cache the result of the Xcodeproj name to avoid repeated globs * Streamline plist loading to avoid reading the file twice * This allows us to drop the read-chunks dependency in next major ### Testing <!-- Please describe in detail how you tested your changes. --> Added a new test for the Info.plist behaviour. All existing tests pass. ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] I added automated test coverage as appropriate for this change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
