breautek opened a new pull request, #640:
URL: https://github.com/apache/cordova-plugin-file/pull/640

   <!--
   Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist is intended as a quick reference, for complete details please 
see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   Android
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   Regression from 
https://github.com/apache/cordova-plugin-file/commit/99ca43990c0bcdf19645367a27f1f8106d1be71d
   
   Code strips out the `file://` protocol for what used to be used by File 
APIs, but in 8.1.1 that was changed to use CordvaResourceApi which expects an 
actual valid URI.
   
   ### Description
   <!-- Describe your changes in detail -->
   
   If the uri object has no scheme set, then set it to the `file` scheme.
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   paramedic tests passes.
   Testing by using camera plugin to capture an image, resolve the `file://` 
uri and attempt to set an image tag `src` attribute to the `fileEntry.toURL()` 
result.
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to 
one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to