dpogue opened a new pull request, #283:
URL: https://github.com/apache/cordova-js/pull/283
Should have added Node 22 to CI _before_ doing the `fs.globSync` change
🤦🏼♂️
### Platforms affected
Windows
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
So `fs.glob` returns paths using the system path separator, while
`fast-glob` and `globby` always return POSIX-style paths. Since we use this
value for module IDs (i.e., `cordova.require('some/module/path')`) we need to
ensure the IDs use POSIX-style separators.
NodeJS apparently still doesn't have an API to fix this beyond just doing
string replacements.
### Description
<!-- Describe your changes in detail -->
Force module IDs to always use POSIX-style path separators.
### Testing
<!-- Please describe in detail how you tested your changes. -->
Ran tests in CI with logging to reproduce and fix the bug.
### Checklist
- [x] I've run the tests to see all new and existing tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
