erisu opened a new pull request, #1807: URL: https://github.com/apache/cordova-android/pull/1807
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> By default, when a plugin is installed, `usePlatformWww` is set to `true`, and the plugin's files are added to the `platform_www` directory. [Reference: cordova-lib install.js line 330](https://github.com/apache/cordova-lib/blob/master/src/plugman/install.js#L330) However, during uninstallation, although `cordova-lib` also sets `usePlatformWww` to `true`, Cordova-Android was overriding this and forcing the option to `false`. This behavior likely originated from a time when the platform supported multiple build systems besides Android Studio. As a result, with the flag set to `false`, plugins were never properly uninstalled from the `platform_www` directory. In contrast, the iOS platform does not alter the `usePlatformWww` flag and successfully removes plugin files from `platform_www` during uninstallation. ### Description <!-- Describe your changes in detail --> Removed the overriding logic. ### Testing <!-- Please describe in detail how you tested your changes. --> - `npm t` - installing and uninstalling plugins. (including multiple plugins). ### Checklist - [x] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
