erisu commented on PR #949: URL: https://github.com/apache/cordova-lib/pull/949#issuecomment-3094599791
> **I think we should stay on 5.8.0.** Yes, I agree. For now, we can stick with Jasmin 5.8.0, and when we start preparing for the release, we can bump it then. It might be awhile from now. > **Latest version of `init-package-json` requires Node.js `^20.17.0 || >=22.9.0`, so I bumped Node to 20.17.0. It might be better to choose the same requirement or 20.5.0.** For now, I'll accept this PR as-is, and we'll set the Node.js requirement to `20.17.0`. I'll submit a follow-up PR to try and remove the `init-package-json` dependency. From what I can tell, the code using it is only called by `cordova-plugman`. As far as I remember, the purpose of `cordova-lib` is to centralize shared code between our CLIs (`cordova-plugman` and `cordova-cli`). Since `cordova-cli` doesn't use this part of the code at all, I think we could move it over to `cordova-plugman`. Once that's done, I'll downgrade the Node.js requirement again within that PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
