shenzhuxi opened a new pull request, #89: URL: https://github.com/apache/cordova-plugin-device-orientation/pull/89
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected Android ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> https://github.com/apache/cordova-plugin-device-orientation/pull/78 gave sinHeading and cosHeading instead of heading like the original plugin. ### Description <!-- Describe your changes in detail --> So, I followed https://github.com/CompassMB/MBCompass replaced deprecated Sensor.TYPE_ORIENTATION. It also handled the screen orientation issue with remapCoordinateSystem. https://github.com/apache/cordova-plugin-device-orientation/issues/51 MBCompass has an unsolved problem - the compass orientation is different when the screen tilts forward/backward. So, I used TYPE_GRAVITY to detect the screen pitch orientation. As long as you don't use the screen facing to the ground (negative pitch), the heading should be correct. ### Testing <!-- Please describe in detail how you tested your changes. --> Samsung Galaxy Tab S5 and Pixel 7a ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
