erisu commented on PR #939: URL: https://github.com/apache/cordova-plugin-camera/pull/939#issuecomment-3626143361
> Thank you @erisu, for explaining everything. So the documentation is wrong about the [`<engines>` tag is deprecated in `plugin.xml`](https://cordova.apache.org/docs/en/13.x-2025.11/plugin_ref/spec.html#engines-and-engine)? Because currently the documentation encourages plugin developers [to just use `cordovaDependencies`](https://cordova.apache.org/docs/en/13.x-2025.11/guide/hybrid/plugins/index.html#adding-engine-requirements) and not additionally the `<engines>` in `plugin.xml`. Should this changed in the documentation or make it more clear? I do not see any statements indicating that the `<engines>` tag is deprecated, but I do see this: > **NOTE:** In Cordova 6.1.0+, the recommended place to specify platform, plugin, and CLI dependencies is in a plugin's `package.json`. See *Specifying Cordova Dependencies* for more information. If anything, I would suggest updating it to: > **NOTE:** Starting in Cordova 6.1.0, it is recommended to include the platform and CLI engine requirements in the plugin's `package.json`, *in addition to* the `<engines>` declaration in `plugin.xml`. See *Specifying Cordova Dependencies* for more information. This wording uses phrases like "**include**" and "**in addition to the `<engines>`**" to make it clear that the `<engines>` tag is not deprecated, and it would be helpful if authors also included `cordovaDependencies`. --- Also, in the **Specifying Cordova Dependencies** documentation, there is this statement: > This feature is intended to eventually replace the [engines element](https://cordova.apache.org/docs/en/13.x-2025.11/plugin_ref/spec.html#engines-and-engine) in plugin.xml. I would not change this. It says "intended to" which does not imply deprecation. It simply describes the long-term goal, which has not yet been completed. --- This suggestion is just my opinion... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
