erisu commented on code in PR #284:
URL: https://github.com/apache/cordova-paramedic/pull/284#discussion_r2604938129
##########
lib/PluginsManager.js:
##########
@@ -42,21 +41,7 @@ class PluginsManager {
installedPlugins.forEach((plugin) => {
// there is test plugin available
if (fs.existsSync(path.join(plugin.dir, 'tests', 'plugin.xml'))) {
- let additionalArgs = '';
-
- // special handling for cordova-plugin-file-transfer
- if (plugin.id.indexOf('cordova-plugin-file-transfer') >= 0) {
- if (this.config.getFileTransferServer()) {
- // user specified a file transfer server address, so
using it
- additionalArgs += ' --variable
FILETRANSFER_SERVER_ADDRESS=' + this.config.getFileTransferServer();
- } else {
- // no server address specified, starting a local server
- const server = new Server(0);
- const fileServerUrl =
`http://${server.getServerIP(this.config.getPlatformId())}:5001`;
- additionalArgs += ' --variable
FILETRANSFER_SERVER_ADDRESS=' + fileServerUrl;
- }
- }
-
+ const additionalArgs = '';
Review Comment:
Yes, I can remove this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
