breautek commented on code in PR #1094:
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/1094#discussion_r2620196934
##########
package-lock.json:
##########
Review Comment:
package-lock should be retained so that constributors & CI gets a consistent
dependency tree on checkout / install.
##########
package.json:
##########
@@ -1,6 +1,6 @@
{
"name": "cordova-plugin-inappbrowser",
- "version": "6.0.1-dev",
+ "version": "7.2.0",
Review Comment:
version should be left unchanged, this is managed as part of the release
process
##########
plugin.xml:
##########
@@ -19,8 +19,8 @@
-->
<plugin xmlns="http://apache.org/cordova/ns/plugins/1.0";
- id="cordova-plugin-inappbrowser"
- version="6.0.1-dev">
+ id="cordova-plugin-inappbrowser"
+ version="7.2.0">
Review Comment:
ditto on version management.
##########
plugin.xml:
##########
@@ -30,25 +30,36 @@
<issue>https://github.com/apache/cordova-plugin-inappbrowser/issues</issue>
<engines>
- <engine name="cordova" version=">=9.0.0"/>
- <engine name="cordova-android" version=">=9.0.0" />
- <engine name="cordova-ios" version=">=6.0.0" />
+ <engine name="cordova" version=">=12.0.0"/>
+ <engine name="cordova-android" version=">=14.0.0" />
+ <engine name="cordova-ios" version=">=7.0.0" />
Review Comment:
These should be left unchanged unless if there is a necessary reason why the
plugin needs a newer version.
If this is necessary, then we'll a description of what are the breaking
changes, and we will probably would want this change to in it's own PR (along
with bumping the version to a major dev (e.g. `7.0.0-dev`).
##########
package.json:
##########
@@ -48,13 +50,20 @@
"cordova": ">=9.0.0"
},
"7.0.0": {
+ "cordova-android": ">=14.0.0",
+ "cordova-ios": ">=7.0.0",
+ "cordova": ">=12"
+ },
+ "8.0.0": {
"cordova": ">100"
}
}
},
"author": "Apache Software Foundation",
"license": "Apache-2.0",
"devDependencies": {
- "@cordova/eslint-config": "^5.0.0"
+ "@cordova/eslint-config": "^5.0.0",
+ "jest": "^30.2.0",
Review Comment:
unit tests should be ran via cordova's paramedic tool which uses jasmine
behind-the-scenes. See the [existing
tests](https://github.com/apache/cordova-plugin-inappbrowser/tree/master/tests).
Ref: https://github.com/apache/cordova-paramedic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
