dpogue commented on code in PR #941:
URL:
https://github.com/apache/cordova-plugin-camera/pull/941#discussion_r2687254070
##########
src/ios/CDVCamera.m:
##########
@@ -156,7 +143,7 @@ - (BOOL)popoverSupported
- index 7 (allowsEditing): NSNumber(BOOL). Allow user to crop/edit.
Default: NO.
- index 8 (correctOrientation): NSNumber(BOOL). Fix EXIF orientation.
Default: NO.
- index 9 (saveToPhotoAlbum): NSNumber(BOOL). Save captured image to
Photos. Default: NO.
- - index 10 (popoverOptions): NSDictionary (iPad only). Popover positioning
and sizing.
+ - index 10 (popoverOptions): NSDictionary (iPad only). Popover positioning
and sizing. - Not used anymore
Review Comment:
We should probably just remove this entirely
##########
www/Camera.js:
##########
@@ -140,19 +137,19 @@ cameraExport.getPicture = function (successCallback,
errorCallback, options) {
const allowEdit = !!options.allowEdit;
const correctOrientation = !!options.correctOrientation;
const saveToPhotoAlbum = !!options.saveToPhotoAlbum;
- const popoverOptions = getValue(options.popoverOptions, null);
const cameraDirection = getValue(options.cameraDirection,
Camera.Direction.BACK);
if (allowEdit) {
console.warn('allowEdit is deprecated. It does not work reliably on
all platforms. Utilise a dedicated image editing library instead. allowEdit
functionality is scheduled to be removed in a future release.');
}
- const args = [quality, destinationType, sourceType, targetWidth,
targetHeight, encodingType,
- mediaType, allowEdit, correctOrientation, saveToPhotoAlbum,
popoverOptions, cameraDirection];
+ const args = [
+ quality, destinationType, sourceType, targetWidth, targetHeight,
encodingType,
+ mediaType, allowEdit, correctOrientation, saveToPhotoAlbum,
+ null, // popoverOptions, iPadOS only, not used anymore
Review Comment:
It's probably better to just remove this parameter entirely rather than
leaving nulls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
