dheeraj12347 commented on PR #1463:
URL: https://github.com/apache/cordova-docs/pull/1463#issuecomment-3762780538
@GitToTheHub Thank you for the review! I've updated both files to use the
cleaner single-line comparison as you suggested:
Changed from:
{% assign normalized_my_entry = include.my_entry | remove: '/' %}
{% assign normalized_entry_url = entry.url | remove: '/' %}
{% if normalized_my_entry == normalized_entry_url %}
To:
{% assign entry_active = include.my_entry | remove: '/' == entry.url |
remove: '/' %}
{% if entry_active %}
This is much cleaner and more readable. Changes have been pushed. Thanks for
the improvement suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
