GitToTheHub commented on PR #942: URL: https://github.com/apache/cordova-plugin-camera/pull/942#issuecomment-3768501732
Hi @dpogue, > CDVPlugin's `hasPendingOperation` is checked in low-memory situations to avoid unloading plugins that are actively doing work: https://github.com/apache/cordova-ios/blob/0b547520951bae7ee90f80aef767e1914a2fc4bc/CordovaLib/Classes/Public/CDVViewController.m#L535 > > The only place that should ever be modifying the value is the plugin's own code, so I think threading conflicts are unlikely (I don't know why we don't have a public setter for that in CDVPlugin...) I looked in [CDVPlugin.h](https://github.com/apache/cordova-ios/blob/0b547520951bae7ee90f80aef767e1914a2fc4bc/CordovaLib/include/Cordova/CDVPlugin.h#L115) which already declares `hasPendingOperation`. So I can remove the declared in property in `CDVCamera.m`, correct?: https://github.com/apache/cordova-plugin-camera/blob/90ad137398e87d219d2e1eeb8b0f61273898a700/src/ios/CDVCamera.m#L97C36-L97C55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
