GitToTheHub commented on code in PR #944:
URL:
https://github.com/apache/cordova-plugin-camera/pull/944#discussion_r2743085927
##########
src/ios/CDVCamera.m:
##########
@@ -298,6 +298,8 @@ - (void)showPHPicker:(NSString*)callbackId
withOptions:(CDVPictureOptions*)pictu
{
// PHPicker must be created and presented on the main thread.
dispatch_async(dispatch_get_main_queue(), ^{
+ // Using just [PHPickerConfiguration init] is more flexible and lets
the picker return items
+ // that aren’t PHAssets (e.g., cloud/shared providers), but it will
not return asset identifiers.
Review Comment:
You are right I made this comment not clear enough. The code used
`pickerResult.assetIdentifier` before to get the image data after, but this
would work only with `[PHPickerConfiguration
initWithPhotoLibrary:[PHPhotoLibrary sharedPhotoLibrary]]`. Using just `init`
opens the picker to more files than it would do when using
`sharedPhotoLibrary`. I made the comment now more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
