GitToTheHub commented on code in PR #1023:
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/1023#discussion_r3201079692
##########
src/android/InAppBrowser.java:
##########
@@ -946,7 +953,11 @@ public boolean onShowFileChooser (WebView webView,
ValueCallback<Uri[]> filePath
WebSettings settings = inAppWebView.getSettings();
settings.setJavaScriptEnabled(true);
settings.setJavaScriptCanOpenWindowsAutomatically(true);
- settings.setBuiltInZoomControls(showZoomControls);
+ // Enables built-in zoom mechanisms, which are on-screen zoom
controls and pinch-to-zoom.
+ // The on-screen zoom controls have to be enabled/disabled
separately after.
+ // The on-screen zoom controls are deprecated since Android
API Level 26 (Android 8).
Review Comment:
Please change the comment to:
```java
// setBuiltInZoomControls enables pinch-to-zoom and also the on-screen zoom
controls
// The zoom controls have to be disabled separately by setDisplayZoomControls
// This is the recommended way by Google
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
