breautek commented on issue #296:
URL: 
https://github.com/apache/cordova-plugin-geolocation/issues/296#issuecomment-4422925820

   > They look to be using new code See 
https://developer.android.com/reference/android/app/permissionui/LocationButtonClient
   > 
   > Added in API 37, would this lead to new development?
   
   Not stating this with certain confidence but I believe that is likely if 
you're implementing custom permission prompts -- which they have an ability to 
customize the style to a degree.
   
   Apache plugin does not actually use the geolocation API directly. It uses 
the webview's geolocation implementation. The plugin is just necessary to make 
the actual permission request for coarse and fine location. So there is very 
little surface area on Cordova's side.
   
   When a javascript geolocation API is used, a [WebChromeClient 
hook](https://github.com/apache/cordova-android/blob/245021782bf4645b0743b5705e59a40e8fbbcaf7/framework/src/org/apache/cordova/engine/SystemWebChromeClient.java#L188)
 is called for the app to handle permission requests.
   
   Cordova will look for cordova plugins to handle that permission request, 
geolocation plugin is one of those plugins.
   
   It's still worth downloading the API 37 emulator and and test against it, 
but I don't think there will be any changes required by Cordova.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to