gabriel2mm commented on issue #1923: URL: https://github.com/apache/cordova-android/issues/1923#issuecomment-4459406951
> Hi, I tested a plain Cordova app with scrollable content and noticed only, that the keyboard is overlying content which cannot be scrolled into the visible area. After closing the keyboard I had no scrolling issues. After applying your fix, the content can be scrolled in the visible area when the soft keyboard is open, which looks good. But this will only work if the preference `AndroidEdgeToEdge` is `false`. When the preference is set to `true`, the keyboard still overlays content which cannot be scrolled into the visible area. I tested the master by setting `AndroidEdgeToEdge` to `true` and `false` without that PR and in both cases the bottom content is overlapped and cannot be scrolled to the visible area. So you PR is an improvement, when `AndroidEdgeToEdge` is false. Yes, this happens because a validation was introduced in the PR https://github.com/apache/cordova-android/pull/1817 checking if edgeToEdge is disabled. Because of this, it won't apply the margin. `int bottom = !canEdgeToEdge && !isFullScreen ? bars.bottom : 0;` I believe it's worth evaluating if it makes sense to keep the edgeToEdge validation in this scenario. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
