GitToTheHub commented on issue #1654: URL: https://github.com/apache/cordova-ios/issues/1654#issuecomment-4479266569
Hi @hitomi0109, I was a little bit fast with my PR and that you can test it. PR #1655 is a step in the right direction, but it won't fully fix your problem on its own — let me explain the current state. What PR #1655 does Before this fix, `CDVSceneDelegate` had no implementation of `scene:continueUserActivity:`, so any `NSUserActivity` delivered by iOS (i.e. Universal Links) was silently dropped and no plugin ever received it. The PR adds that handler and broadcasts the activity as a new `CDVPluginContinueUserActivityNotification` via `NSNotificationCenter`, consistent with how URL-scheme opens are handled. Why your plugin still won't work after the PR `cordova-plugin-universallinks-fix` was written for cordova-ios 7, where Universal Links were delivered to `AppDelegate.application(_:continue:restorationHandler:)`. On cordova-ios 8, iOS routes them to the `SceneDelegate` instead, so the plugin's existing `AppDelegate` hooks never fire regardless of this PR. For the plugin to work on cordova-ios 8, it needs to be updated to observe the new `CDVPluginContinueUserActivityNotification` notification. What you can do in the meantime The workaround from your issue report is still valid — override `scene(_:continue:)` in your app's `SceneDelegate.swift` and forward to `AppDelegate` manually. Just note that `CDVDelegate` in your snippet should be `CDVSceneDelegate`: I'd recommend opening an issue or PR against `cordova-plugin-universallinks-fix` pointing to #1655 and the new notification name, so the plugin can be updated to support cordova-ios 8 properly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
