gabriel2mm commented on code in PR #1939:
URL: https://github.com/apache/cordova-android/pull/1939#discussion_r3307971669
##########
framework/src/org/apache/cordova/SystemBarPlugin.java:
##########
@@ -129,13 +127,10 @@ private void setStatusBarBackgroundColor(JSONArray
argbVals) {
int r = argbVals.getInt(1);
int g = argbVals.getInt(2);
int b = argbVals.getInt(3);
- String hexColor = String.format("#%02X%02X%02X%02X", a, r, g, b);
- int parsedColor = parseColorFromString(hexColor);
- if (parsedColor == INVALID_COLOR) return;
+ overrideStatusBarBackgroundColor =
String.format("#%02X%02X%02X%02X", a, r, g, b);
Review Comment:
Thanks a lot for the suggestions. They were really helpful — I updated and
retested the code, and everything seems to be working fine from what I can see.
Updated as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
