dpogue opened a new pull request, #1663:
URL: https://github.com/apache/cordova-ios/pull/1663

   
   
   <!--
   Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist is intended as a quick reference, for complete details please 
see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Xcode is getting more strict about minimum supported OS requirements, what 
used to be a warning about version numbers being out of range is being turned 
into an error. In Xcode 27 beta 1, our minimum of 13.0 is an error because the 
lowest supported target version is 15.0.
   
   
   ### Description
   <!-- Describe your changes in detail -->
   
   To avoid needing to raise our actual minimum OS version unnecessarily, we 
can use an Xcode macro that automatically results in the minimum supported OS 
version in the current Xcode version. These macros were introduced in Xcode 14, 
which is older than our minimum Xcode requirement.
   
   The end result of this is that the realistic minimum supported OS version 
for a Cordova app will be determined by the Xcode version used to build it.
   
   It doesn't seem to care about the minimum version declared in Package.swift 
and whether that's in the range of supported versions or not.
   
   I would feel better if there were a way to use this conditionally and still 
set a hardcoded minimum, or a way to see clearly what the Xcode-supported 
minimum is, but I can't see a way to do that without delving into complex 
xcconfig chaining :(
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Opened the project and ran tests in Xcode 27 beta 1 with no issues.
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to