GitToTheHub opened a new pull request, #971: URL: https://github.com/apache/cordova-plugin-camera/pull/971
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected iOS ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> @erisu noticed after PR #873 was merged, if there should be any cleanup procedures after stop was called. For example, on Android, when takePicture is executed this.imageUri is set and gets not cleared. PR #970 fixes this for Android. On iOS no files need to be cleaned up when `stop` is called, for this [camera.cleanup](https://github.com/apache/cordova-plugin-camera#module_camera.cleanup) is intended. But location updates will be cancelled, if they are used, and also the temporary `metadata` variable. ### Description <!-- Describe your changes in detail --> - stop and release location updates during stop cleanup - Defensive clear of temporary `metadata` variable - reuse the same cleanup path whether a picker is presented or not - no files need to be cleaned up. These are intended to be removed via `cleanup` call. Generated-By: GPT-5.3-Codex ### Testing <!-- Please describe in detail how you tested your changes. --> ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
