MaximBelov commented on PR #1167: URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/1167#issuecomment-5284255178
Test app so this can be checked on a device, pinned to this branch with screenshots: https://github.com/MaximBelov/cordova-iab-pr1167-backgroundcolor-demo Interesting — I get a different default from you on the same version. Android 16, Pixel 9a emulator in light mode: the empty frame is white, and captures with and without `backgroundcolor=#FFFFFF` come out byte-identical. It is black only when the emulator is in dark mode. You saw black in light mode on 16, and white on 10. That divergence looks like the argument for the option rather than against it. The default depends on Android version, device and the host app's theme, so an app that needs a predictable frame can't rely on it. Hardcoding white would also change behaviour for every existing app, whereas the option changes nothing unless it is passed. Also fixed a bug this surfaced: the colour used to stick across opens — once set, a later open without the option kept it for the life of the process. `2b897e7d` assigns the field unconditionally. Verified on a device: amber open, then an open with no option measures `rgb(255,255,255)` instead of `rgb(255,204,0)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
