GitToTheHub commented on code in PR #1695:
URL: https://github.com/apache/cordova-ios/pull/1695#discussion_r3850789507
##########
CordovaLib/Classes/Public/CDVViewController.m:
##########
@@ -746,8 +746,6 @@ - (void)createStatusBarView
[self.statusBar.trailingAnchor
constraintEqualToAnchor:self.view.trailingAnchor].active = YES;
[self.statusBar.topAnchor
constraintEqualToAnchor:self.view.topAnchor].active = YES;
[self.statusBar.bottomAnchor
constraintEqualToAnchor:self.view.safeAreaLayoutGuide.topAnchor].active = YES;
-
- self.statusBar.hidden = YES;
Review Comment:
I see you removed the line which initially hides the status bar. Did you
test, if this has no regressions? For e.g. the status bar should be not visible
when `viewport-fit=cover` is set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
