dpogue opened a new pull request, #1697:
URL: https://github.com/apache/cordova-ios/pull/1697

   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Hopefully closes GH-1590 based on the investigation work from @deguchi
   
   
   ### Description
   <!-- Describe your changes in detail -->
   This should allow the app bundle and the display name to have whatever 
Unicode characters they want, but the actual executable within the bundle will 
always be named App and hopefully avoid any issues Xcode has with finding and 
properly code-signing the executable.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Built locally and confirmed that the app bundle had the name provided in 
config.xml and the executable file within the bundle was name "App".
   
   I am not able to test making an App Store build.
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to