GitToTheHub commented on code in PR #1701:
URL: https://github.com/apache/cordova-ios/pull/1701#discussion_r3870774777
##########
CordovaLib/Classes/Public/CDVViewController.m:
##########
@@ -905,7 +910,11 @@ - (void)showSplashScreen:(BOOL)visible
- (void)showStatusBar:(BOOL)visible
{
#if !defined(TARGET_OS_VISION) || !TARGET_OS_VISION
- [self.statusBarBackground setAlpha:(visible ? 1 : 0)];
+ _statusBarHidden = !visible;
+
+ UIScrollView *scrollView = [self.webView
performSelector:@selector(scrollView)];
+ [self scrollViewDidChangeAdjustedContentInset:scrollView];
+
Review Comment:
I just want to remove this code in
`scrollViewDidChangeAdjustedContentInset:`:
```objc
if (_statusBarHidden) {
self.statusBarBackground.hidden = true;
```
because this will be only the case when `showStatusBar:` is called with `NO`
and somebody might wonder why `self.statusBarBackground.hidden` is set here to
`true`, when `_statusBarHidden` is `YES`.
In `showStatusBar:` everything would stay what you added. Just
`self.statusBarBackground.hidden= _statusBarHidden` would be added for clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
