[ 
https://issues.apache.org/jira/browse/CB-5012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13789744#comment-13789744
 ] 

ASF subversion and git services commented on CB-5012:
-----------------------------------------------------

Commit 64ce537ddabd659d36d6dfc8b8fd4cdfbd8de5ac in branch refs/heads/master 
from [~goya]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=64ce537 ]

[CB-5012]: No whitespace in empty plist string nodes.


> Crash occurs because plugman adds extra information in iOS Info.plist when 
> installing a plugin
> ----------------------------------------------------------------------------------------------
>
>                 Key: CB-5012
>                 URL: https://issues.apache.org/jira/browse/CB-5012
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugman
>    Affects Versions: Master
>            Reporter: Shazron Abdullah
>            Assignee: Brett Rudd
>            Priority: Critical
>             Fix For: 3.2.0
>
>         Attachments: KeyboardTest-Info.after-plugman.plist, 
> KeyboardTest-Info.original.plist
>
>
> See attached .original.plist and .after-plugman.plist.
> The plugin.xml used is: 
> https://github.com/apache/cordova-labs/blob/86fb3afef5aaaba8e82e5bf0719b74b4a07582e0/statusbar/plugin.xml
> (note the value it tries to add in the iOS Info.plist).
> What plugman does is, it adds extra info (newlines, spaces) as the string 
> value for     the keys NSMainNibFile and NSMainNibFile~ipad in Info.plist. 
> They had no values before. At runtime, iOS will search for these "values" and 
> not finding the .nib files to load, then crash.
> This is critical for plugins that need to modify the Info.plist, like the 
> Facebook PhoneGap plugin. There was a pull request for this, but I don't know 
> why it was closed exactly: https://github.com/apache/cordova-plugman/pull/21
> Expected:
> plugman should not modify plist keys that have empty string values.
> Actual:
> plugman adds a newline, 6 spaces, and another newline for keys that have 
> empty string values.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to