[ 
https://issues.apache.org/jira/browse/CB-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13891362#comment-13891362
 ] 

ASF subversion and git services commented on CB-5438:
-----------------------------------------------------

Commit a85f693ca5d15cd5c5204f81c1542100fac13300 in branch refs/heads/master 
from [~BBosman]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=a85f693 ]

CB-5438 Exclude local symlinks from jshint

Both /src/test/androidexec.js and /src/test/iosexec.js are symlinks to
/src/android/exec.js and /src/ios/exec.js

Symlinks don't work on the Windows platform and are represented there as
a text file with the contents being a text description of where it
should be pointing at.

The problem is that the jshint task of the build tries to parse those
'text' files as js files, which fails for obvious reasons.

My solution is to explicitly exclude those 2 symlink files from the
jshint task. The files they point at are included in the src/**/*.js
jshint src setting, so they will get checked anyway.

Now we can succesfully run grunt build on Windows.


> Can't build/test cordova-js on Windows
> --------------------------------------
>
>                 Key: CB-5438
>                 URL: https://issues.apache.org/jira/browse/CB-5438
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaJS
>    Affects Versions: Master
>         Environment: Windows 8 x64
> Node v0.10.13
>            Reporter: qi
>            Priority: Critical
>
> Simply run 'grunt build', got,
> Running "jshint:src" (jshint) task
> Linting lib/test/androidexec.js ...ERROR
> [L1:C1] E030: Expected an identifier and instead saw '.'.
> ../android/exec.js
> [L1:C2] E033: Expected an operator and instead saw '.'.
> ../android/exec.js
> [L1:C3] E033: Expected an operator and instead saw '/'.
> ../android/exec.js
> [L1:C4] W033: Missing semicolon.
> ../android/exec.js
> [L1:C4] W015: Expected 'android' to have an indentation at 1 instead at 4.
> ../android/exec.js
> [L1:C19] W033: Missing semicolon.
> ../android/exec.js
> [L1:C4] W117: 'android' is not defined.
> ../android/exec.js
> [L1:C12] W117: 'exec' is not defined.
> ../android/exec.js
> Linting lib/test/iosexec.js ...ERROR
> [L1:C1] E030: Expected an identifier and instead saw '.'.
> ../ios/exec.js
> [L1:C2] E033: Expected an operator and instead saw '.'.
> ../ios/exec.js
> [L1:C3] E033: Expected an operator and instead saw '/'.
> ../ios/exec.js
> [L1:C4] W033: Missing semicolon.
> ../ios/exec.js
> [L1:C4] W015: Expected 'ios' to have an indentation at 1 instead at 4.
> ../ios/exec.js
> [L1:C15] W033: Missing semicolon.
> ../ios/exec.js
> [L1:C4] W117: 'ios' is not defined.
> ../ios/exec.js
> [L1:C8] W117: 'exec' is not defined.
> ../ios/exec.js
> Warning: Task "jshint:src" failed. Use --force to continue.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to