[ 
https://issues.apache.org/jira/browse/CB-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948764#comment-13948764
 ] 

ASF GitHub Bot commented on CB-6357:
------------------------------------

GitHub user jsoref opened a pull request:

    https://github.com/apache/cordova-cli/pull/153

    CB-6357 platform check - install each platform to determine working + 
version number

    The other changesets (Refactor, exports, silence output, sort output, fix 
indentation) are split because it's a lot easier to understand things 
individually.
    
    The evolution here is partially w/ an eye to eventually have these 
functions be usable by other entities too.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/blackberry/cordova-cli cb_6357

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-cli/pull/153.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #153
    
----
commit b5d8ce7915e3875d427acb1583cb46fd046f238e
Author: Josh Soref <jso...@blackberry.com>
Date:   2014-03-24T21:29:57Z

    CB-6357 platform: Refactor into distinct functions

commit bca4b6fef31364cbb4d8977a52881316a30321b9
Author: Josh Soref <jso...@blackberry.com>
Date:   2014-03-24T21:30:46Z

    CB-6357 platform: provide exports for functions

commit 5911893d8f29e0d8341583c075b8152d359e428b
Author: Josh Soref <jso...@blackberry.com>
Date:   2014-03-27T01:49:03Z

    CB-6357 call_into_create: support no output

commit a67a478ec7dcff6c93bcf1c42d30e3d6653cd00b
Author: Josh Soref <jso...@blackberry.com>
Date:   2014-03-26T14:43:21Z

    CB-6357 platform check - install each platform to determine working + 
version number

commit 66cb9612a98df47d82ce6bc123be3ce4fca855a3
Author: Josh Soref <jso...@blackberry.com>
Date:   2014-03-27T01:55:14Z

    CB-6357 platform check: sort output

commit 6000ba91151a2ef1bc465b97f6e8fda20e660b45
Author: Josh Soref <jso...@blackberry.com>
Date:   2014-03-27T01:56:44Z

    CB-6357 platform: fix indentation

----


> platform check should install each platform to determine if they're 
> functional and their version number
> -------------------------------------------------------------------------------------------------------
>
>                 Key: CB-6357
>                 URL: https://issues.apache.org/jira/browse/CB-6357
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI
>    Affects Versions: 3.5.0
>            Reporter: Josh Soref
>            Assignee: Josh Soref
>
> Currently `cordova platform check` has a few behaviors which are not 
> necessarily ideal:
> 1. It relies on the platforms.js file to have valid versions which match what 
> is actually in the cached ~/.cordova/lib space.
> 2. If a platform is installed for which there's a newer version which won't 
> install (e.g. you're on Windows and you have iOS installed), it could tell 
> you that there's an upgrade available, however, you won't be able to install 
> it.
> We'd like to fix these limitations by having platform check actually run the 
> version script against a live project. This should mean that there will not 
> be any false positives: what you see is what you really could get.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to